Fix Regex#inspect
with non-literal-compatible options
#14575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch
Regex#inspect
only uses the literal syntax when all option flags can be represented. If options includes additional flags, it uses a more extensive representation based on the constructor form.I'm not sure if the helper methods
#inspect_literal
and#inspect_extensive
should really be exposed. I can't see any specific use case for calling them directly instead of#inspect
. We could make themprivate
and move all documentation to#inspect
.Resolves #14530