Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for IOCP::OverlappedOperation #14723

Conversation

straight-shoota
Copy link
Member

This is a light refactor of IOCP::OverlappedOperation to simplify the implementation.

  • Add OverlappedOperation#to_unsafe as standard format for passing to C functions
  • Add OverlappedOperation.unbox for the reverse
  • Drop unnecessary OverlappedOperation#start to simplify the logic

@straight-shoota straight-shoota added this to the 1.13.0 milestone Jun 18, 2024
@straight-shoota straight-shoota merged commit b14be1e into crystal-lang:master Jun 20, 2024
61 checks passed
@straight-shoota straight-shoota deleted the refactor/iocp-operation-to_unsafe branch June 20, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants