Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig template on crystal init command. #4422

Merged

Conversation

akzhan
Copy link
Contributor

@akzhan akzhan commented May 17, 2017

@asterite
Copy link
Member

This project (Crystal) uses this editor configuration, but other Crystal projects are free to use whatever configuration they want. I don't think this should be included in every Crystal project.

@asterite asterite closed this May 20, 2017
@oprypin
Copy link
Member

oprypin commented May 20, 2017

Are other Crystal projects not free to use a different license?

@akzhan
Copy link
Contributor Author

akzhan commented May 20, 2017

@asterite this .editorconfig just follow crystal language convention at all. Like crystal tool format one.

No one requires to use it, but it is fine default. Like use git by default etc.

@RX14
Copy link
Contributor

RX14 commented May 20, 2017

I think including an editorconfig file is a good default, just like the gitignore and license we include.

@asterite asterite reopened this May 20, 2017
@asterite
Copy link
Member

OK, sorry, I shouldn't have closed this. Have someone else decide :-)

@mverzilli mverzilli added this to the Next milestone May 22, 2017
@mverzilli mverzilli merged commit 241dbc2 into crystal-lang:master May 22, 2017
@mverzilli
Copy link

Thanks!

@akzhan akzhan deleted the add-editorconfig-on-crystal-init branch May 26, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants