New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tls scheme to HTTP::Server#bind and rename HTTP::Server#bind_ssl #6533
Add tls scheme to HTTP::Server#bind and rename HTTP::Server#bind_ssl #6533
Conversation
a0e4bd3
to
8182fe2
Compare
8182fe2
to
daaed8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to make such a minimal breaking change to an API just introduced?
Yes, I think its fair. People using it should still be actively working on their projects. |
Yeah, it's too bad 0.26.0 is already done. Maybe something breaks and we need to ship 0.26.1 right away, then this could be included in the bug fix ;) |
Kemal already update it's api to use bind_ssl. |
You mean to temporarily re-add |
Yes. |
This adds
tls://
scheme forHTTP::Server#bind
and makes it default in documentation. It also renamesHTTP::Server#bind_ssl
toHTTP::Server#bind_tls
.Follow-up on #6500 (discussion starting at #6500 (comment))