New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `Iteratory#slice_when` and `Iterator#chunk_while` #7159

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@asterite
Copy link
Contributor

asterite commented Dec 7, 2018

Part of #7142

Having both slice_when and chunk_while, given that the difference is only whether the condition is inverted or not, is debatable. However, one might be more readable than other depending on each case. Same as why while/until, if/unless exist.

@RX14

This comment has been minimized.

Copy link
Member

RX14 commented Dec 7, 2018

Merge conflicts!

@asterite asterite force-pushed the asterite:feature/slice_when branch from d9bd742 to f3f0211 Dec 7, 2018

@asterite

This comment has been minimized.

Copy link
Contributor Author

asterite commented Dec 7, 2018

@RX14 rebased

@RX14

RX14 approved these changes Dec 7, 2018

@RX14 RX14 added this to the 0.27.1 milestone Dec 7, 2018

@RX14 RX14 merged commit 6bdadcb into crystal-lang:master Dec 7, 2018

1 of 4 checks passed

ci/circleci: test_darwin CircleCI is running your tests
Details
ci/circleci: test_linux32 CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment