Adds URI#query_params method #8090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/std/uri_spec.cr
Outdated
| describe "#query_params" do | ||
| it do | ||
| uri = URI.parse("http://foo.com?id=30&limit=5#time=1305298413") | ||
| uri.query_params.should eq(HTTP::Params.parse("id=30&limit=5")) |
There was a problem hiding this comment.
Technically, the spec would be more reliant if the HTTP::Params instance was created from a spec. We're not testing Params.parse here, but still...
There was a problem hiding this comment.
What do you mean? Something like:
expected_params = HTTP::Params.new({ "id" => ["30"], "limit" => ["5"]} )
uri.query_params.should eq(expected_params)
asterite
reviewed
Aug 27, 2019
asterite
approved these changes
Aug 28, 2019
straight-shoota
approved these changes
Sep 3, 2019
|
@rodrigopinto Could you please squash the commits except the first one? I'd like to merge this as two commits, a spec refactor and a feature addition. |
… of the query. Using @asterite suggestions as it is more idiomatic. Co-Authored-By: Ary Borenszweig <asterite@gmail.com>
rodrigopinto
force-pushed
the
rp-add-query_params-to-uri
branch
from
0b88830
to
4bf0ca0
Compare
|
@straight-shoota it is done. |
|
Thank you @rodrigopinto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding a
URI#query_paramswhich will generate aHTTP::Paramsinstance parsed from theURI#query.Example:
👉 it closes #8085