Use CRYSTAL_OPTS env variable as default compiler options #8900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just bikesheddding, but why |
|
No special reasons. I'm happy to change it. |
|
I'm fine with that name too, I was just curious. |
jhass
approved these changes
Mar 12, 2020
oprypin
reviewed
Mar 12, 2020
| @@ -585,4 +590,8 @@ class Crystal::Command | |||
| @color = false if ARGV.includes?("--no-color") || ENV["TERM"]? == "dumb" | |||
| Crystal.error msg, @color, exit_code: exit_code | |||
| end | |||
|
|
|||
| private def use_crystal_opts | |||
| @options = ENV.fetch("CRYSTAL_OPTS", "").split.concat(options) | |||
There was a problem hiding this comment.
Is this a declaration that nobody will ever need to use spaces within options to Crystal compiler?
Would be nice to support shell quoting.
There was a problem hiding this comment.
Good catch. Definitely an improvement.
There was a problem hiding this comment.
Is there a safe already way to split that respecting shell quoting?
There was a problem hiding this comment.
No. We'd need to port this from Ruby: https://ruby-doc.org/stdlib-2.5.1/libdoc/shellwords/rdoc/Shellwords.html (or do something similar)
makenowjust
added a commit
to makenowjust/crystal
that referenced
this pull request
Jun 20, 2020
Fixed crystal-lang#9509 Ref crystal-lang#8900 (comment) This commit adds `Process.split`, which works as like `Shellwords.split` in Ruby. And, this is used to parse `CRYSTAL_OPTS`. I'm not sure `Process.split` is good naming. However I have no idea of better name. And also, I'm not sure Windows version of `Process.split` is needed.
bcardiff
added a commit
that referenced
this pull request
Jun 23, 2020
* Fix `CRYSTAL_OPTS` parsing Fixed #9509 Ref #8900 (comment) This commit adds `Process.split`, which works as like `Shellwords.split` in Ruby. And, this is used to parse `CRYSTAL_OPTS`. I'm not sure `Process.split` is good naming. However I have no idea of better name. And also, I'm not sure Windows version of `Process.split` is needed. * Rename `Process.split` to `parse_arguments` * Use `in?` instead of `includes?` Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl> * Let `Process.parse_arguments` raise an error against unclosed quote This also fix backslash behavior in double quote as POSIX. * Handle error on `CRYSTAL_OPTS` parsing Co-authored-by: Jonne Haß <me@jhass.eu> * Remove debug output from example Co-authored-by: Brian J. Cardiff <bcardiff@gmail.com> * Fix method name in example Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl> Co-authored-by: Jonne Haß <me@jhass.eu> Co-authored-by: Brian J. Cardiff <bcardiff@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make the compiler read the
CRYSTAL_OPTSenvironment variable and use is as additional compiler flags in some commands: build, eval, run, spec and .This is handy to configure the compiler to be more pedantic regarding deprecations for example. The compiler is sometimes used in postinstall tasks where injecting flags is not possible.
With this and #8899 we should be able to checks deprecation along all the source code used to build and app.