Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SemanticVersion::Prerelease comparable #8991

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Make SemanticVersion::Prerelease comparable #8991

merged 1 commit into from
Apr 2, 2020

Conversation

makenowjust
Copy link
Contributor

There is no reason that SemanticVersion::Prerelease does not include Comparable.

@bcardiff bcardiff merged commit aaa1851 into crystal-lang:master Apr 2, 2020
@bcardiff bcardiff added this to the 0.34.0 milestone Apr 2, 2020
@makenowjust makenowjust deleted the fix/semantic_version/comparable-prerelease branch April 3, 2020 03:23
carlhoerberg pushed a commit to carlhoerberg/crystal that referenced this pull request Apr 29, 2020
@makenowjust @carlhoerberg
Let SemanticVersion::Prerelease include Comparable (crystal-lang#…
631abdd 
…8991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib
Projects
None yet
Milestone
0.34.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makenowjust @asterite @RX14 @bcardiff