Make File.rename overwrite the destination file on Windows, like elsewhere #9038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where The compiler, for example, relies on it here: https://github.com/crystal-lang/crystal/blob/0bb3fe98d0b2698e646ab6eb24097eb6e4e8bafa/src/compiler/crystal/compiler.cr#L702
11 tasks
RX14
approved these changes
Apr 10, 2020
RX14
added
kind:bug
There was a problem hiding this comment.
@RX14 That was a quick merge...
But I'll approve it after the fact 👍
|
it's windows-only, you only need one approval |
carlhoerberg
pushed a commit
to carlhoerberg/crystal
that referenced
this pull request
Apr 29, 2020
…where (crystal-lang#9038) The compiler, for example, relies on it here: https://github.com/crystal-lang/crystal/blob/0bb3fe98d0b2698e646ab6eb24097eb6e4e8bafa/src/compiler/crystal/compiler.cr#L702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler, for example, relies on it here:
crystal/src/compiler/crystal/compiler.cr
Line 702 in 0bb3fe9
You could argue whether it's desirable. For example, Python, to preserve backwards compatibility where the behavior differed like this for ages, decided to keep
renameas replacing on Unix but erroring on Windows, but also addedreplaceto replace on both. So on Unix they don't have anyrenamewhich would error out if the destination exists.Another important caveat is that replacing a file like that is atomic on Unix, but on Windows that is impossible to achieve.
Let me know what you think, I could do the same as Python instead.