Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log: allow nil as context raw values #9121

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Log: allow nil as context raw values #9121

merged 1 commit into from
Apr 20, 2020

Conversation

bcardiff
Copy link
Member

paulcsmith
paulcsmith reviewed Apr 19, 2020
View reviewed changes
Copy link
Contributor

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo! Thanks @bcardiff

@bcardiff bcardiff added this to the 0.35.0 milestone Apr 20, 2020
@bcardiff bcardiff merged commit 7e06c6e into crystal-lang:master Apr 20, 2020
@bcardiff bcardiff deleted the feature/log-nil-context branch April 20, 2020 13:27
@bcardiff bcardiff mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith left review comments

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:log
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bcardiff @paulcsmith @RX14