Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeNode methods to check what "type" the node is #9270

Merged
merged 2 commits into from
May 15, 2020
Merged

TypeNode methods to check what "type" the node is #9270

merged 2 commits into from
May 15, 2020

Conversation

Blacksmoke16
Copy link
Member

  • Add methods to TypeNode to check if its a module, class, or struct
  • Adds specs and updates docs for #nilable?, #abstract? and #union?

@Blacksmoke16
Add methods to TypeNode to check if its a module, class, or struct
1f3b567 
Adds specs and updates docs for `#nilable?`, `#abstract?` and `#union?`
jhass
jhass approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@jhass jhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, otherwise 👍

src/compiler/crystal/macros.cr Outdated Show resolved Hide resolved
@Blacksmoke16 @jhass
Fix typo in struct? documentation
1ae9795 
Co-authored-by: Jonne Haß <me@jhass.eu>
@Blacksmoke16
Copy link
Member Author

Bump. Can I get another review on this?

watzon
watzon approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@watzon watzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. I could see this coming in handy.

@bcardiff bcardiff added this to the 0.35.0 milestone May 14, 2020
@bcardiff bcardiff merged commit d49375b into crystal-lang:master May 15, 2020
@Blacksmoke16 Blacksmoke16 deleted the additonal-TypeNode-methods branch May 15, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@bcardiff bcardiff bcardiff approved these changes

@watzon watzon watzon approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:macros
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Blacksmoke16 @jhass @bcardiff @watzon