Fix double string escape in XML::Node#content= #9300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libxml2 already escapes special characters in node content, there's no need for the custom `escape` method. It lead to double escape which turns `<foo>` content into `&ltfoo&>`.
RX14
approved these changes
May 30, 2020
jhass
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libxml2 already escapes special characters in node content, there's no need for the custom
escapemethod. It lead to double escape which turns<foo>content into&lt;foo&>.The escape method was introduced in #4089 but there's no mention of this escape behaviour in neither the PR nor the linked issue and there have been no specs for this. So I assume it was just wrongly added.
/cc @RX14