Cleanup YAML/JSON Any#dig methods #9415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind applying the same to datum? |
|
Interesting this |
|
Internal and I wanted to avoid early generalization. It was used in log's config and context. But config was never merged in the end. |
|
We can let this as-is for now then. All tests pass, except the darwin test was canceled; don't know why. Note: I cannot view Circle CI logs anymore, it redirects to https://circleci.com/vcs-authorize/ (?!) :( |
straight-shoota
approved these changes
Jun 9, 2020
Any#[] always return an Any, so it is always diggable. This also means the exception is superfluous.
j8r
force-pushed
the
cleanup-json-yaml-any-dig
branch
from
c5d210a
to
7a409a0
Compare
|
Is it possible to move forward on this? |
bcardiff
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any#[] always return an Any, so it is always diggable.
This also means the exception is superfluous.
The logic inside the methods is also simplified, and return types added.