Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Fix Log.context.set docs for hash based data #9470

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

bcardiff
Copy link
Member

Fixes #9449

cc: @z64

@asterite
Copy link
Member

No need to do this here, or now, but I noticed that the docs for Log::Context are completely empty, except for a few methods. Maybe something to improve, showing a couple of examples of how it's used. All other types seem to have at least one line of documentation.

@z64
Copy link
Contributor

z64 commented Jun 12, 2020

Thanks! 👍

@bcardiff bcardiff merged commit 79f3022 into crystal-lang:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log context: Outdated documentation, or broken feature, using hash as top-level context
4 participants