[WIP] Explicitly specify target for Darwin Intel crystal build #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
changed the title
miry
force-pushed
the
darwin-build-arm64
branch
4 times, most recently
from
8e5c037
to
dbcc79a
Compare
miry
changed the title
By default uses the target of the system where the script is executed. If run darwin build on MacOS M1 laptop, it generates 2 arm binaries. And command `lito` returns error that both files have same arch. Reproduction of the problem: ``` $ llvm-config --host-target arm64-apple-darwin23.0.0 $ make crystal stats=true release=true Using /usr/local/bin/llvm-config [version= 15.0.7] CRYSTAL_CONFIG_BUILD_COMMIT="1f592eca6" CRYSTAL_CONFIG_PATH='$ORIGIN/../share/crystal/src' SOURCE_DATE_EPOCH="1699639716" CRYSTAL_CONFIG_LIBRARY_PATH= ./bin/crystal build --no-debug -D strict_multi_assign .... $ file .../crystal/embedded/bin/crystal .../crystal/embedded/bin/crystal: Mach-O 64-bit executable arm64 ```
miry
force-pushed
the
darwin-build-arm64
branch
from
dbcc79a
to
e5a5658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default uses the target of the system where the script is executed. If run darwin build on MacOS M1 laptop, it generates 2 arm binaries. And command
litoreturns error that both files have same arch.Reproduction of the problem:
Problems
Currently I found that
make crystal target=x86_64-apple-darwin release=truefromcrystalrepo is not working for me. Looking for way to build dependencies in correct arch.Relies on changes from #267 and #266