-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make llvm_bin work for arm and correct llvm archive name #267
base: master
Are you sure you want to change the base?
Conversation
✅ Running CI for this branch against latest crystal repo: https://app.circleci.com/pipelines/github/miry/crystal/266/workflows/096d15ce-b2c2-4105-9a0f-dcdd9284d942 🟥 Testing LLVM build in CircleCI: https://app.circleci.com/pipelines/github/miry/distribution-scripts/5/workflows/66f028fa-3526-4d8f-b1c2-96c314b8dec2/jobs/1 -> Out of time. ✅ Testing LLVM build in Github Actions: https://github.com/crystal-lang/distribution-scripts/actions/runs/7417309967/job/20183604232 ✅ Run the final test in Github Actions: https://github.com/miry/distribution-scripts/actions/runs/7421977550/job/20196397502 Tested localy:
|
75bdead
to
971b722
Compare
I found there is posobility to run Action without creating a custom branch. https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow What do you think to use manual triggering, instead of keep branch build_llvm? |
5fe41d3
to
4c84b5f
Compare
Allow to override target architecture sufix in archive name in tgz_package. tgz_package uses build platform for naming archives. When build packages for multiple architectures like x86_64 and arm, then the archive name is not correct. Update the script of tgz_package to check for configuration option `ohai['target_arch']` as target arch name. It allows to specify architecture in project like: ``` ohai['target_arch'] = 'universal' dependency 'tgz_package' ``` Presenting GitHub Actions as an efficient solution for building LLVM from the ground up, seamlessly replicating the functionality of CircleCI. Unlike the extended duration of the CircleCI task, a new GitHub Actions workflow ensures a comprehensive build of LLVM, addressing time limitations and guaranteeing the successful completion of the package build process.
4c84b5f
to
8f2ab59
Compare
@straight-shoota It is ready for review. |
name: Darwin LLVM build | ||
|
||
on: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested really this approach, I think it is required to be merged in master, before the button appears in Actions tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think it'll only show up when merged into the main branch.
Currently the llvm_bin points to archive:
http://crystal-lang.s3.amazonaws.com/llvm/llvm-15.0.7-3-darwin-x86_64.tar.gz
As I see from changes ed5f1f9 it should be
universal
.Would it make sense to rename the filename and update the
distribution-scripts/omnibus/config/software/llvm_bin.rb
Line 21 in f2c1e13
Example:
UPDATE: 2014-01-05
Identified that sufix added by omnibus/software/tgz_package.
It is always uses the current platform.
Update script to allow override the suffix.
Overall it could be replaced to be constant
universal
, as all packages suppose to be universal. But I would keep it as it is, and replace one by one.CircleCI is not enough to finish task to build llvm_bin, so I introduced Github Actions as well for llvm build. Example of Github action build: https://github.com/miry/distribution-scripts/actions/runs/7421977550