Use libgc from Alpine for building the compiler on Linux #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beta-ziliani
reviewed
May 2, 2024
Comment on lines
37
to
+42
| # This overrides default CRYSTAL_LIBRARY_PATH baked into the binary (starting with 1.2.0) | ||
| # or configured via wrapper script (before 1.2.0) because we want to link against | ||
| # the newly-built libraries, not the ones shipped with the bootstrap compiler. | ||
| ENV CRYSTAL_LIBRARY_PATH=/bdwgc/.libs/ | ||
| # the regularly installed libraries, not the ones shipped with the bootstrap compiler. | ||
| # This particularly affects libgc which was bundled upto Crystal 1.12 | ||
| ENV CRYSTAL_LIBRARY_PATH="" | ||
|
|
There was a problem hiding this comment.
Wouldn't it make more sense to simply remove this?
There was a problem hiding this comment.
We're using a bootstrap compiler which ships a bundled libgc.a in its CRYSTAL_LIBRARY_PATH. It's necessary to explicitly override the path to use the system library instead.
Otherwise the build would fail because the bundled library is built against glibc but we're linking musl.
beta-ziliani
approved these changes
May 3, 2024
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
May 3, 2024
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@8c3a9f6 This includes the following changes: * crystal-lang/distribution-scripts#303 * crystal-lang/distribution-scripts#301 * crystal-lang/distribution-scripts#302 * crystal-lang/distribution-scripts#300 * crystal-lang/distribution-scripts#298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need a specially-built version of libgc anymore and can use the package from Alpine, just like with any other dependency.
Resolves part of #285