Drop building libgc on Linux #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
May 3, 2024
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@8c3a9f6 This includes the following changes: * crystal-lang/distribution-scripts#303 * crystal-lang/distribution-scripts#301 * crystal-lang/distribution-scripts#302 * crystal-lang/distribution-scripts#300 * crystal-lang/distribution-scripts#298
straight-shoota
added a commit
that referenced
this pull request
May 14, 2024
This reverts commit bb025ed.
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to ship a specially-built version of libgc anymore. This patch drops it from the regular package and moves the build instructions to the bundled package which also includes other necessary libraries.
For this reason we're still keeping
CRYSTAL_CONFIG_LIBRARY_PATHso that it's still possible to add bundled libraries to that path.Resolves part of #285