Fix spec for running under 32-bit Linux #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restricted to the valid time range for that system
asterite
reviewed
Jun 24, 2020
| @@ -419,7 +419,7 @@ describe "install" do | |||
|
|
|||
| with_shard(metadata) do | |||
| run "shards install" | |||
| File.touch "shard.lock", Time.utc(1900, 1, 1) | |||
| File.touch "shard.lock", Time.utc(1901, 12, 14) | |||
There was a problem hiding this comment.
I wonder why such an old time is needed here 🤔
Can't we just use a date from last year or something like that?
There was a problem hiding this comment.
Something pre 1970 makes sense I guess in case somebody boots their system without a hardware clock and it starts from 0 :D
There was a problem hiding this comment.
Good luck with doing whatever on such machine (think SSL certificates with specific timeframe) ;)
bcardiff
approved these changes
Jun 24, 2020
straight-shoota
approved these changes
Jun 24, 2020
taylor
pushed a commit
to vulk/shards
that referenced
this pull request
Aug 11, 2020
* Restricted to the valid time range for that system
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
* Restricted to the valid time range for that system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See crystal-lang/crystal#9542 for more info.