Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spec for running under 32-bit Linux #416

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Fix spec for running under 32-bit Linux #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/integration/install_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ describe "install" do

with_shard(metadata) do
run "shards install"
File.touch "shard.lock", Time.utc(1900, 1, 1)
File.touch "shard.lock", Time.utc(1901, 12, 14)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why such an old time is needed here 🤔

Can't we just use a date from last year or something like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something pre 1970 makes sense I guess in case somebody boots their system without a hardware clock and it starts from 0 :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck with doing whatever on such machine (think SSL certificates with specific timeframe) ;)

mtime = File.info("shard.lock").modification_time
run "shards install"
File.info("shard.lock").modification_time.should eq(mtime)
Expand Down