Don't use POSIX-specific shell constructs #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of work to bring 'shards' to Windows.
5 tasks
Sija
reviewed
Sep 19, 2020
| @@ -113,7 +113,7 @@ module Shards | |||
|
|
|||
| protected def self.has_git_command? | |||
| if @@has_git_command.nil? | |||
| @@has_git_command = Process.run("command -v git", shell: true).success? | |||
| @@has_git_command = (Process.run("git", ["--version"]).success? rescue false) | |||
There was a problem hiding this comment.
Suggested change
| @@has_git_command = (Process.run("git", ["--version"]).success? rescue false) | |
| @@has_git_command = Process.run("git", ["--version"]).success? rescue false |
There was a problem hiding this comment.
It can work both ways but just consider what advantages we're weighing here (picking one or the other):
- Saving two characters.
- Not having to think what the rescue really applies to every time when reading the code. I literally didn't know what the priority would be and I wanted to save everyone the cognitive load and the possible bugs.
There was a problem hiding this comment.
Ok, I thought it's pretty clear what's going on here (there's nothing else that 'rescue' could apply to), but it's your call.
PS. for me the cognitive load is asking myself why did u do that in the first place ;)
jhass
approved these changes
Sep 20, 2020
|
@bcardiff have you had a chance to look at my pull requests to Shards? |
straight-shoota
approved these changes
Oct 30, 2020
5 tasks
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
This is part of work to bring 'shards' to Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of work to bring 'shards' to Windows.