Honour CRYSTAL env var
#534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although it is not used. But that's the pattern followed in config.cr for now.
Avoid requiring crystal to be available in path. This can allow wrapper scripts on shards and have a cleaner override of the CRYSTAL_VERSION to use to resolve dependencies.
|
Specs fail on Windows |
|
Yeah, that was #532 |
|
Seems not ¯\_(ツ)_/¯ |
|
Yeah, now we get the actual failures on windows. Not the unrelated ones. |
|
Windows doesn't like |
oprypin
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reissue of #415 reduced to the original scope. It makes
shardshonour theCRYSTALenvironment variable when calling thecrystalprogram to determine the Crystal version and forshards build.Resolves #406