Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile.win #615

Merged

Conversation

HertzDevil
Copy link
Contributor

The docs-related targets are dropped, because manfiles do not make sense on Windows. Everything else should work, in particular setting up the Git commit hash and the build date for bin\shards.exe --version. Setting %SHARDS% to false also works as long as both curl and tar are available (Windows 10 should come with them already).

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@HertzDevil HertzDevil mentioned this pull request Feb 16, 2024
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, I don't like this duplication at all. 😢 But I guess there's no other way (without throwing everything over).

@straight-shoota straight-shoota added this to the 0.18.0 milestone Feb 19, 2024
@straight-shoota straight-shoota merged commit 7f24467 into crystal-lang:master Feb 21, 2024
7 checks passed
@HertzDevil HertzDevil deleted the feature/windows-makefile branch February 21, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants