Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace multi-abi by allContracts and add a note regarding this change #254

Merged
merged 19 commits into from
Jul 11, 2023

Conversation

ggrieco-tob
Copy link
Member

No description provided.

@montyly
Copy link
Member

montyly commented Apr 18, 2023

Note: there are multiple multi-abi left in this branch, including in the section titles

@ggrieco-tob ggrieco-tob requested a review from montyly as a code owner May 1, 2023 15:33
@ggrieco-tob
Copy link
Member Author

This one is also ready for review @montyly

@montyly
Copy link
Member

montyly commented May 4, 2023

I noticed that its at least still present here: https://github.com/crytic/building-secure-contracts/blob/fix-use-allContracts/program-analysis/echidna/basic/common-testing-approaches.md

We should do a grep on the repo to ensure its up to date everywhere

@ggrieco-tob
Copy link
Member Author

I did another merge with master and grep, I think fixed all the cases (except where it is explained that it changed in previous releases)

@montyly montyly added this pull request to the merge queue Jul 11, 2023
Merged via the queue into master with commit 1a7d9e7 Jul 11, 2023
18 checks passed
@montyly montyly deleted the fix-use-allContracts branch July 11, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants