Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove mstksg/get-package #952

Merged
merged 3 commits into from Feb 24, 2023
Merged

ci: remove mstksg/get-package #952

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9360b30
ci: remove `mstksg/get-package`
elopez Feb 22, 2023
08ba244
ci: drop redundant Linux dependencies
elopez Feb 22, 2023
6eb4cdd
ci: adjust caching
elopez Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 9 additions & 14 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -17,18 +17,11 @@ jobs:
os:
- ubuntu-20.04
- macos-latest
include:
- os: ubuntu-20.04
apt-get: autoconf automake libtool
- os: macos-latest
brew: automake

steps:
- name: Get Packages
uses: mstksg/get-package@v1
with:
brew: ${{ matrix.brew }}
apt-get: ${{ matrix.apt-get }}
- name: Get Packages (macOS)
if: runner.os == 'macOS'
run: brew install automake

- name: Checkout
uses: actions/checkout@v3
Expand All @@ -37,19 +30,21 @@ jobs:
uses: actions/cache@v3
with:
path: ~/.local/
key: ${{ runner.os }}-local-v4
key: ${{ runner.os }}-local-v5-${{ hashFiles('.github/scripts/install-*') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a hash of the scripts so it gets invalidated in case we ever update a dependency. Right now the cache has a fixed name and it'll still use old binaries even if we update the scripts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a good change 👍


- name: Cache Stack
uses: actions/cache@v3
with:
path: ~/.stack
key: ${{ runner.os }}-stack-v4
path: |
~/.stack
.stack-work
key: ${{ runner.os }}-stack-v5-${{ hashFiles('package.yaml', 'stack.yaml') }}

- name: Cache Cabal
uses: actions/cache@v3
with:
path: ~/.cabal
key: ${{ runner.os }}-cabal-v4
key: ${{ runner.os }}-cabal-v5-${{ hashFiles('package.yaml', 'stack.yaml') }}

- name: Build Libraries
run: |
Expand Down