Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow checking contract source against known OZ source hashes #1134

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

rmi7
Copy link
Contributor

@rmi7 rmi7 commented Mar 18, 2022

No description provided.

@rmi7 rmi7 requested a review from montyly March 18, 2022 15:59
@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2022

This pull request introduces 2 alerts when merging 666e813 into 81daa56 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@@ -65,6 +67,16 @@ def is_openzepellin(contract: "Contract") -> bool:
return is_zep


def is_openzepellin_strict(contract: "Contract") -> bool:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo:

Suggested change
def is_openzepellin_strict(contract: "Contract") -> bool:
def is_openzeppelin_strict(contract: "Contract") -> bool:

@montyly montyly mentioned this pull request Apr 15, 2022
9 tasks
@montyly montyly merged commit 5a6b630 into dev Aug 8, 2022
@montyly montyly deleted the add-oz-sourcehash-checking branch August 8, 2022 13:23
@rmi7 rmi7 changed the title WIP allow checking contract source against known OZ source hashes allow checking contract source against known OZ source hashes Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants