Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve identifier path support #1227

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Improve identifier path support #1227

merged 4 commits into from
Aug 15, 2022

Conversation

montyly
Copy link
Member

@montyly montyly commented Jun 7, 2022

The parsing was failing due to the new IdentifierPath in case of modifier: the modifier name needs to be used instead of its signature

@0xalpharush 0xalpharush mentioned this pull request Jun 22, 2022
17 tasks
@0xalpharush
Copy link
Member

0xalpharush commented Jul 13, 2022

I think this can be fixed more simply by adding all modifier names to the dictionary in addition to their signatures, e.g.

modifiers = {m.full_name:  m for m in contract.modifiers if not m.is_shadowed}
modifiers |= {m.name:  m for m in contract.modifiers if not m.is_shadowed}

I guess there's a potential for clashes?

@montyly montyly merged commit a277925 into dev Aug 15, 2022
@montyly montyly deleted the dev-modifier-identifier-path branch August 15, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants