Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match on solidity sig and full name for custom errors #1349

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

0xalpharush
Copy link
Member

@0xalpharush 0xalpharush commented Aug 16, 2022

Fixes #1173, fixes #1174

@lgtm-com
Copy link

lgtm-com bot commented Aug 16, 2022

This pull request introduces 1 alert when merging 8c245cc into a277925 - view on LGTM.com

new alerts:

  • 1 for Unused import

@0xalpharush 0xalpharush force-pushed the dev-fix-customer-error-contract-arg branch from 8c245cc to 3e9859c Compare August 16, 2022 22:53
@0xalpharush 0xalpharush changed the title remove address conversion for contract in custom error solidity sig match on solidity sig and full name for custom errors Aug 16, 2022
@montyly montyly merged commit 10413a3 into dev Aug 17, 2022
@montyly montyly deleted the dev-fix-customer-error-contract-arg branch August 17, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants