Recommend reading variable without additional STATICCALL #1484
Conversation
|
This pull request introduces 1 alert when merging fd2fb33 into b96beea - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
0xalpharush
force-pushed
the
detect/self-call
branch
from
506584e
to
83f74f1
Compare
|
This pull request introduces 1 alert when merging 83f74f1 into b96beea - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Closes https://github.com/trailofbits/slither-private/issues/319. Whenever the this.variable syntax is used, it results in an additional STATICCALL. We can recommend replacing this with an operation that is a direct SLOAD. Note, this isn't detect for old versions of solidity like 0.4.25 since they didn't use STATICALL (see is_static_call in HighLevelCall's API).
Replaces https://github.com/trailofbits/slither-private/pull/322