Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Not in UPPER_CASE_WITH_UNDERSCORES' warning for public constant vars removed #1530

Merged
merged 5 commits into from
Jan 25, 2023
Merged

'Not in UPPER_CASE_WITH_UNDERSCORES' warning for public constant vars removed #1530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62902d7
'No uppercase' warning for public vars removed
bart1e Dec 18, 2022
d400d19
Tests added
bart1e Jan 12, 2023
1af71e6
Tests fixed
bart1e Jan 13, 2023
df912be
Old tests removed
bart1e Jan 13, 2023
339d661
test_detectors updated
bart1e Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion slither/detectors/naming_convention/naming_convention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ def _detect(self): # pylint: disable=too-many-branches,too-many-statements
# For ERC20 compatibility
if var.name in ["symbol", "name", "decimals"]:
continue

if var.visibility == "public":
continue
if not self.is_upper_case_with_underscores(var.name):
info = [
"Constant ",
Expand Down
4 changes: 4 additions & 0 deletions tests/detectors/naming-convention/0.4.25/no_warning_for_public_constants.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
contract A
{
uint256 public constant myVal = 0;
}
3 changes: 3 additions & 0 deletions ...naming-convention/0.4.25/no_warning_for_public_constants.sol.0.4.25.NamingConvention.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[
[]
]
4 changes: 4 additions & 0 deletions tests/detectors/naming-convention/0.5.16/no_warning_for_public_constants.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
contract A
{
uint256 public constant myVal = 0;
}
3 changes: 3 additions & 0 deletions ...naming-convention/0.5.16/no_warning_for_public_constants.sol.0.5.16.NamingConvention.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[
[]
]
4 changes: 4 additions & 0 deletions tests/detectors/naming-convention/0.6.11/no_warning_for_public_constants.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
contract A
{
uint256 public constant myVal = 0;
}
3 changes: 3 additions & 0 deletions ...naming-convention/0.6.11/no_warning_for_public_constants.sol.0.6.11.NamingConvention.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[
[]
]
4 changes: 4 additions & 0 deletions tests/detectors/naming-convention/0.7.6/no_warning_for_public_constants.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
contract A
{
uint256 public constant myVal = 0;
}
3 changes: 3 additions & 0 deletions ...s/naming-convention/0.7.6/no_warning_for_public_constants.sol.0.7.6.NamingConvention.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[
[]
]
20 changes: 20 additions & 0 deletions tests/test_detectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,26 @@ def id_test(test_item: Test):
"naming_convention.sol",
"0.7.6",
),
Test(
all_detectors.NamingConvention,
"no_warning_for_public_constants.sol",
"0.4.25",
),
Test(
all_detectors.NamingConvention,
"no_warning_for_public_constants.sol",
"0.5.16",
),
Test(
all_detectors.NamingConvention,
"no_warning_for_public_constants.sol",
"0.6.11",
),
Test(
all_detectors.NamingConvention,
"no_warning_for_public_constants.sol",
"0.7.6",
),
Test(
all_detectors.ControlledDelegateCall,
"controlled_delegatecall.sol",
Expand Down