'Not in UPPER_CASE_WITH_UNDERSCORES' warning for public constant vars removed #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for addressing this issue! Would you mind adding a detector test please? If you need any pointers lmk. |
bart1e
force-pushed
the
no_uppercase_for_public_vars
branch
from
3db1e32
to
d400d19
Compare
bart1e
requested review from
montyly,
0xalpharush and
smonicas
as code owners
|
Test added, as requested. I took a test from the issue itself. |
|
Awesome, thanks. The OP left out the constant attribute so that needs to be added to truly test it #1262 (comment) |
0xalpharush
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1262.
Don't call
is_upper_case_with_underscoreson public constant variables.