Bugs fixed in strongly connected components and cyclomatic complexity algorithms #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart1e
requested review from
montyly,
0xalpharush and
smonicas
as code owners
|
As an aside, it may be useful to create helper methods on functions to get nodes in postorder and reverse postorder. |
|
great catch @bart1e ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File
code_complexity.pyhad two bugs in it. This PR fixes both of them.The first bug was related to strongly connected components algorithm: the final DFS (or
assignin this case) should be performed on reversed postorder order instead on just postorder.The second issue concerned calculating cyclomatic complexity:
Pin the formula should be a number of connected components (always1in case of solidity functions) instead of strongly connected components.