Merge pull request #1617 from bart1e/strongly_connected_components_fix

Bugs fixed in strongly connected components and cyclomatic complexity algorithms

slither/utils/code_complexity.py

@@ -52,7 +52,7 @@ def assign(node: "Node", root: List["Node"]):
             for father in node.fathers:
                 assign(father, root)
 
-    for n in l:
+    for n in reversed(l):
         component: List["Node"] = []
         assign(n, component)
         if component:
@@ -74,9 +74,9 @@ def compute_cyclomatic_complexity(function: "Function") -> int:
     # where M is the complexity
     # E number of edges
     # N number of nodes
-    # P number of connected components
+    # P number of connected components (always 1 for a function)
 
     E = compute_number_edges(function)
     N = len(function.nodes)
-    P = len(compute_strongly_connected_components(function))
+    P = 1
     return E - N + 2 * P