run tests in parallel locally with makefile #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xalpharush
commented
Mar 28, 2023
0xalpharush
commented
Mar 30, 2023
Merged
montyly
reviewed
Apr 9, 2023
|
|
||
| contracts = slither.compilation_units[0].contracts | ||
| a = contracts[0] if contracts[0].is_interface else contracts[1] | ||
| assert len(a.references) == 2 | ||
| lines = _sort_references_lines(a.references) | ||
| assert lines == [12, 18] | ||
|
|
||
|
|
||
| def test_references(): |
There was a problem hiding this comment.
No, the test was calling two nested tests and I split them to be their own test. https://github.com/crytic/slither/pull/1808/files/d1b9e8288900d6b7d75025b3f589adec0b68a045#diff-fee079d1aa52bfd03e4808f11f095beadfb074ecb24718f690004bb271bd4754R80-R103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Makefile that creates a developer env (
make dev), run linting validation (make lint), reformats and modifies the code (make reformat), runs tests (make test). The guidance in CONTRIBUTING.md has been updated to reflect these and the modifications to the test directory structure. In addition, the usage of solc-select was modified to use a fixture (solc_binary_path) which takes a lock on the binary while the test runs, allowing the tests to be run in parallel