Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot testing insta #1820

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Snapshot testing insta #1820

merged 2 commits into from
Apr 17, 2023

Conversation

0xalpharush
Copy link
Member

Switches to pytest-insta which has a more straightforward way to review and update the "expected" result of test cases (see https://github.com/vberlier/pytest-insta#command-line-options).

Depends on #1808

@0xalpharush 0xalpharush mentioned this pull request Apr 4, 2023
Merged
@0xalpharush 0xalpharush marked this pull request as ready for review April 4, 2023 16:06
@montyly montyly merged commit 84ffb3b into dev Apr 17, 2023
37 checks passed
@montyly montyly deleted the snapshot-testing-insta branch April 17, 2023 18:14
@0xalpharush 0xalpharush mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elopez elopez Awaiting requested review from elopez

@montyly montyly Awaiting requested review from montyly montyly is a code owner

@smonicas smonicas Awaiting requested review from smonicas smonicas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xalpharush @montyly