Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functionid printer to account for some getters taking input #211

Merged
merged 2 commits into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@Xenomega
Copy link
Member

commented Apr 25, 2019

This pull request aims to resolve #210 . The function-id printer will now consider that some public variable getter functions take input:

  • Getters for mapping types take a key as input.
  • Getters for array types take a uint256 index as input.

The printer will now generate the correct function identifiers.

Fix functionid printer to account for getters having parameters (key …
…is input in mappings, uint256 index is input for arrays).

@Xenomega Xenomega changed the title Fix functionid printer to account for getters having parameters (key … Fix functionid printer to account for some getters taking input Apr 25, 2019

@montyly montyly merged commit 04c147f into master Apr 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@montyly montyly deleted the dev-functionid-fix branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.