Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve external function detector: merge together shadowed function #334

Merged
merged 5 commits into from
Oct 2, 2019

Conversation

montyly
Copy link
Member

@montyly montyly commented Sep 12, 2019

For example

contract C{
    function f() public{

    }
}

contract D is C{
    function f() public{
        
    }
}

contract E{
    function f() public{
        
    }
}

Will result in

f() should be declared external:
	- C.f() (a.sol#2-4)
	- D.f() (a.sol#8-10)
f() should be declared external:
	- E.f() (a.sol#14-16)

The goal is to facilitate review of the finding. If the visibility is changed in the most derived contract, it must be changed in the base too. It will help the upcoming slither-format tool

@montyly montyly merged commit 1ed272b into dev Oct 2, 2019
@montyly montyly deleted the dev-external-functions branch October 2, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant