Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upper and lower bound comparison for solc detector #378

Closed
wants to merge 3 commits into from
Closed

Add upper and lower bound comparison for solc detector #378

wants to merge 3 commits into from

Conversation

uivlis
Copy link
Contributor

@uivlis uivlis commented Nov 27, 2019

Should fix #320

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gitcoinbot gitcoinbot mentioned this pull request Nov 27, 2019
Closed
montyly
montyly requested changes Nov 27, 2019
View reviewed changes
Copy link
Member

@montyly montyly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thank you for this PR. I think the solution is closed to be working, but we probably want to tweak a bit the version comparison so it will be more robust with newer versions

slither/detectors/attributes/incorrect_solc.py Outdated Show resolved Hide resolved
@uivlis @yxliang01
Update slither/detectors/attributes/incorrect_solc.py
375d3c8 
Co-Authored-By: Xiao Liang <yxliang01@users.noreply.github.com>
@uivlis uivlis requested a review from montyly November 27, 2019 21:14
@montyly
Copy link
Member

montyly commented Nov 28, 2019

I merged the branch in dev, thanks to @uivlis and @yxliang01 for the work!

@montyly montyly closed this Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxliang01 yxliang01 yxliang01 left review comments

@montyly montyly Awaiting requested review from montyly montyly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

solc-version detector: Missing 0.5.11
4 participants
@uivlis @CLAassistant @montyly @yxliang01