solc-version detector: Missing 0.5.11

[montyly]

0.5.11 is incorrectly reported as an old version.

[yxliang01]

@montyly I proposed #357 to fix this. However, I feel the logic can be made more generic, so that no need to update the list of too recent versions whenever there's new solc version. E.g. set a version number to be the latest version that is well-tested and known to be stable. Then, for a version that is after this version, if it is a known vulnerable version, report vulnerable text, otherwise, too recent. Possibly, it can automatically pick the latest version among the ALLOWED_VERSIONS?

[montyly]

Thanks @yxliang01 for the contribution!

It's a good idea! I agree we can just parse the latest element of 0.5.X and report when its greater than our recommended version.

[montyly]

Task Description

Change the logic of the solc-version detector (see discussions above)

Acceptance criteria

• The solc-version detector extracts the minor version of 0.4.x/0.5.x and compares it to a lower bound and an upper bound

Required Skills

• Experience with Python 3.6
• Experience with Solidity smart contracts
• Experience with Slither

Feel free to ask questions here, or join our slack (#ethereum)

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 100.0 SAI (100.0 USD @ $1.0/SAI) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $115,157.00 more funded OSS Work available on the Gitcoin Issue Explorer

[karansinghgit]

@montyly why is there a need for a lower bound and upper bound?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 6 days, 10 hours from now.
Please review their action plans below:

1) uivlis has been approved to start work.

I will test version_number against upper and lower bound of ALLOWED_VERSIONS and will also test it not to be in BUGGY_VERSIONS.
2) b-m-f has applied to start work (Funders only: approve worker | reject worker).

I have already worked on solc-select and would like to pick this up.
I will implement a check against the minor version and compare against the ALLOWED_VERSIONS variable.
A correct message ( "version too high" || "version to low") will be reported.

Learn more on the Gitcoin Issue Details page.

[montyly]

Hi @uivlis and @b-m-f, thank you for your interest in this issue.

This requires only one contributor, so we will go with the first one who applied. @ceresstation can you approve @uivlis ? Thank you

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 100.0 SAI (100.0 USD @ $1.0/SAI) has been submitted by:

1. @uivlis

@ceresstation please take a look at the submitted work:

• PR by @uivlis

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $100,123.26 more funded OSS Work available on the Gitcoin Issue Explorer

[montyly]

The issue was solved in #378 by @uivlis.

@ceresstation can you send the bounty? Thanks

[uivlis]

@ceresstation I sent you a payment reminder, maybe you forgot about this one?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

The funding of 100.0 SAI (100.0 USD @ $1.0/SAI) attached to this issue has been approved & issued to @uivlis.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $75,976.24 more funded OSS Work available on the Gitcoin Issue Explorer