-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/debug uis #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntirely to the debounced part of its logic
…tructions and to validate the ui event logic works
…low level events that now can be awaited
… UIs before completing the task
…sts (and updated testing libraries to their latest versions)
…t this code still can be included in a Unity project (which uses .NET Standard 2.1), see https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version#defaults
…thing the same as the default RestFactory except the ping logic which seems to not work correctly for IPs in the latest Unity version
…ll without stacktrace"
…net one for all other platforms
…named to make it clear it extends default features of IDisposable plus holds the state if the object is disposed
…e chain to listen to events to this target key value store. This also deprecates MutationObserverKeyValueStore which was a previous implementation of this concept
…ew Observable key value store and a debug UI as a next step
…ot only in the demo scenes but in any app
…ing runtime in any application
… to show how to use it
…m/item?id=32189416 The PromiseMap represents a caching pattern where instead of having a key:value cache instead key:promise-that-resolves-to-value—doing is used, this gives you dog piling prevention for free, because the first lookup of a value triggers the computation to fetch it while subsequent lookups wait on the same promise to resolve—or resolve instantly if the computation has completed
…orrectly return the same substate for the same input state every time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6732 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 7ba4c6f and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is