Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement score increment during testing #65

Merged
merged 4 commits into from
Mar 12, 2019

Conversation

dlqs
Copy link

@dlqs dlqs commented Mar 12, 2019

fills in remaining part of the ans command

@dlqs dlqs requested a review from KerrynEer March 12, 2019 09:36
if (!model.checkIfInsideTestSession()) {
throw new CommandException(Messages.MESSAGE_INVALID_COMMAND_OUTSIDE_TEST_SESSION);
}
if (model.checkIfCardAlreadyAnswered()) {
throw new CommandException(Messages.MESSAGE_INVALID_ANSWER_COMMAND);
}
model.setCardAsAnswered();
Card cardToMark = lastShownList.get(0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should we use getCurrentTestedCard method from model to get the cardToMark? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I changed it. Thx!

Copy link

@KerrynEer KerrynEer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@KerrynEer KerrynEer merged commit 9620adb into cs2103-ay1819s2-w10-4:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants