Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deletefolder and change command #72

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

afterdusk
Copy link

@afterdusk afterdusk commented Mar 13, 2019

deletefolder and change (partial functionality) have been implemented.

change

At the moment, there is no concept of a home directory. As such, folders and their hidden/implicit indices exist, but we are unable to see them on the GUI. We can jump from folder to folder with change <INDEX>, a behaviour that will eventually be modified to executable only on the home directory.

The other half of the change command (returning to the home directory), will be implemented along with the home directory.

deletefolder

deletefolder <INDEX> behaves as expected, removing the folder at the specified index. Note that if you delete a folder that is currently being displayed, the UI will not refresh itself until you execute a change command. As with change, this command will eventually only be executable from the home directory.

Do let me know if any bugs are encountered.

Copy link

@dlqs dlqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Very good!

@dlqs dlqs merged commit a3dc71f into cs2103-ay1819s2-w10-4:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants