Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration and junit tests for test session #74

Merged
merged 19 commits into from
Mar 16, 2019
Merged

Add integration and junit tests for test session #74

merged 19 commits into from
Mar 16, 2019

Conversation

KerrynEer
Copy link

@KerrynEer KerrynEer commented Mar 16, 2019 •
edited

  • Refactor some default examples in comandTestUtil
  • Test Command hardcoded functionality replaced with using ActiveFolderIndex, so test command internally enters the folder (to update again once enter folder functionality is implemented)
  • Integration and junit tests for test, end and answer commands

To do:

  • End Command to internally exit the folder (to implement once exit folder functionality is implemented)
  • To add GUI tests and systems tests in the future

KerrynEer and others added 18 commits March 13, 2019 00:14
@KerrynEer
Merge pull request #5 from cs2103-ay1819s2-w10-4/master
aa7d5fd 
Create answer command and update score
@KerrynEer
Merge pull request #6 from cs2103-ay1819s2-w10-4/master
4f0d84c 
Merge PR for mid v1.2 features
@KerrynEer
Remove unnecessary code in UI for test session
4d282fb
@KerrynEer
Modify test feature to internally enter the folder in model
192d2b6 
- Modify testCardFolder() to take in cardFolderIndex as parameter
- Set activeCardFolderIndex in testCardFolder()
@KerrynEer
Refactor find to search in SearchCommandTest
4e51f7c
@KerrynEer
Add End Test Session Command Tests
7599c0e
@KerrynEer
Add javadocs for EndCommandTest
e157fce
@KerrynEer
Add Answer Command Equals and correct answer tests
bf8ecca
@KerrynEer
Refactor valid questions and answers in commandTestUtil
2a32bd0
@KerrynEer
Refactor ques and ans desc in commandTestUtil
2627729
@KerrynEer
Add wrong ans attempt and invalid ans command test
237d8b5
@KerrynEer
Add invalid ans command test
60d645b 
- for when question is already answered
@KerrynEer
Remove extra line about setting activeCardFolderIndex
67a6287 
- already done in execute method in testCommand
@KerrynEer
Add TestCommand valid and invalid tests
f31f6be
@KerrynEer
Fix typo in comment
3514fb8
@KerrynEer
Test equals in test command tests
a570b54
@KerrynEer
Add currentTestedCard related tests in modelManagerTest
f258656
@KerrynEer
Add todo to exit folder in end test session
86daeae
@KerrynEer KerrynEer added this to the v1.2 milestone Mar 16, 2019
afterdusk
afterdusk approved these changes Mar 16, 2019
View reviewed changes
Copy link

@afterdusk afterdusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@afterdusk afterdusk merged commit 3c8e7aa into cs2103-ay1819s2-w10-4:master Mar 16, 2019
@KerrynEer KerrynEer deleted the addTests branch March 18, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afterdusk afterdusk afterdusk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KerrynEer @afterdusk