Add sorting #75
Merged
Add sorting #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- currently sort command is for ascending score - list command will now also sort in alphabetical order
- so that the sort command has something to sort on - the rest of the crew are left with zero scores so that other commands can assume that those are brand new unanswered cards
- cards are equal as long as question and answer are equal - this is to fix bug with adding new cards
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
sortcommandSort comand will sort the active filtered cards by percentage score, in ascending order. The sort method is also implemented for ModelManager so that the active filtered cards can be sorted with any provided comparator.
Since we need a way to go back to the "default" ordering (questions in lexicographic order), I also modified the
listcommand to first do a sort before listing. So alistis now really asortin lexicographic order plus alist.For user story #35
Ready for review