Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add report #97

Merged
merged 31 commits into from
Mar 28, 2019
Merged

Add report #97

merged 31 commits into from
Mar 28, 2019

Conversation

dlqs
Copy link

@dlqs dlqs commented Mar 26, 2019

Add report feature. For #95 and epic #32. Displays graph, and line that changes depending on how you performed. And list of questions and scores.

I've decided to make this full screen because it works only when inside a folder anyways, and should only work for the current folder.

More checks on invalid commands to be implemented. Ready for review

ignore coverage pls

dlqs added 30 commits March 26, 2019 00:12
 - shhh, no one saw this commit...
 - since report will be displayed in fullscreen, i thought that might as well
   use the END command to exit the screen as well
 - previously report command required an index i.e. report INDEX
 - but now since the report command is only valid inside a folder, I changed it
   to just display the report for the folder
@dlqs dlqs requested a review from afterdusk March 27, 2019 09:21
@dlqs dlqs added this to the v1.3 milestone Mar 27, 2019
Copy link

@afterdusk afterdusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@afterdusk afterdusk merged commit b715eff into cs2103-ay1819s2-w10-4:master Mar 28, 2019
@dlqs dlqs mentioned this pull request Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants