Add deck #23
Closed
Add deck #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsot
reviewed
Mar 13, 2019
| import seedu.address.logic.commands.RedoCommand; | ||
| import seedu.address.logic.commands.SelectCommand; | ||
| import seedu.address.logic.commands.UndoCommand; | ||
| import seedu.address.logic.commands.*; |
There was a problem hiding this comment.
Please undo this and configure intellij such that it does not automatically collapse import statements.
| @@ -10,4 +10,10 @@ | |||
| public static final String MESSAGE_INVALID_CARD_DISPLAYED_INDEX = "The card index provided is invalid"; | |||
| public static final String MESSAGE_CARDS_LISTED_OVERVIEW = "%1$d cards listed!"; | |||
|
|
|||
| public static final String MESSAGE_DUPLICATE_DECK = "This deck already exists in TopDeck!"; | |||
There was a problem hiding this comment.
Change to "A deck with this name already exists!"
| * Returns an unmodifiable view of the filtered list of decks | ||
| */ | ||
| ObservableList<Deck> getFilteredDeckList(); | ||
|
|
||
| /** Returns an unmodifiable view of the filtered list of persons */ |
| public ObservableList<Card> getFilteredCardList() { | ||
| return model.getFilteredCardList(); | ||
| } | ||
| public ObservableList<Deck> getFilteredDeckList() { return model.getFilteredDeckList(); } |
There was a problem hiding this comment.
Don't put everything in a single line. Intellij shows code in a single line to save vertical space but the underlying code is actually formatted properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt for deck feature