Person to card #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create card class base off the person class implementation.
TopDeck with the undo feature
Change the method signature of the Model API.
xsot
reviewed
Mar 1, 2019
|
The checks that have not been updated are:
|
Bug found due to the difference in find for person and card. For person, first name alone should be unique but for cards, the first word may give many matches,
|
Things left:
The UI and app is working generally, so nothing huge is broken. Yay!! |
Additions to the number of cards in the test case due to the Delete System Test.
…s by lexicographical order.
|
Do not merge the branch yet as there are still remnants of old code from AddressBook. |
Update ParserUtil to only parse tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiating the change from Person object in AB4 to card object. The end goal is to change the list of Persons in AB4 to a list of cards. Deck structure will not be implemented in this PR.
Not ready yet, but draft PR is called so that everyone can see and comment on how they think would be best to structure the card.