Big changes to UI and list-appt is working #117
Conversation
amuletxheart
changed the title
| @@ -401,6 +421,37 @@ private void ensureSelectedMedHistIsValid(ListChangeListener.Change<? extends Me | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Ensures {@code selectedAppointment} is a valid appointment in {@code filteredAppointments}. | |||
There was a problem hiding this comment.
neat and clean logic that ensures a selected appointment. However it would be better to provide some test cases.
| } | ||
|
|
||
| boolean wasSelectedAppointmentReplaced = | ||
| change.wasReplaced() && change.getAddedSize() == change.getRemovedSize() |
There was a problem hiding this comment.
hacky way of comparing the size of the change to check if the appointment is replaced. Perhaps can find a better check by comparing other factors
| @@ -11,7 +11,7 @@ | |||
| public class GuiSettings implements Serializable { | |||
|
|
|||
| private static final double DEFAULT_HEIGHT = 600; | |||
| private static final double DEFAULT_WIDTH = 740; | |||
| private static final double DEFAULT_WIDTH = 1000; | |||
There was a problem hiding this comment.
good width set to account for 3 columns of different lists. However, the default starting list can still be buggy and hide some words if the parameter are too long. For example, some parts of address will be hidden at the start.
| </Label> | ||
| </HBox> | ||
| <HBox> | ||
| <Label text="Patient ID: " /> |
There was a problem hiding this comment.
nice layout of the appointment list in the UI. glad to see a huge leap in the interface!
| <Label fx:id="doctorId" styleClass="cell_small_label" text="\$doctorId" /> | ||
| </HBox> | ||
| <HBox> | ||
| <Label text="Date: " /> |
There was a problem hiding this comment.
can be compressed to 1 since they are similar objects
No description provided.