refresh medhist panel when deletion executed #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is a good addition to solve the issue where your medical history browser panel does not get updated when a patient/doctor is deleted. You made efforts to follow the existing coding conventions and refactored "magic numbers" to constants instead. Overall, good job!
siyingpoof
reviewed
Apr 13, 2019
| public static final String DEFAULT_MED_HIST_PAGE = ""; | ||
|
|
||
| public static final String MESSAGE_PATIENT_DELETED = "Patient Deleted."; |
There was a problem hiding this comment.
Good catch, here you found some "magic numbers" and refactored them into constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.