Updated JsonUtil #94
Merged
Updated JsonUtil #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now condition stores a Pattern, pattern, and an int, minToSatisfy (signifiying the minimum number of unique modules must match the pattern in order to satisfy the condition). Removed conditionName attribute from Condition class. PrimitiveRequirement stores a list of Conditions. Also changed classes and tests that depended on the new PrimitiveRequirement and Condition classes. Created new Json files for course due to the structural changes above. Realised that completing at least 40 modules is not really a Graduation requirement since NUS counts modular credits instead of module count. But we can leave it for now.
Creates Json object from an string that contains the path of the file to be read as an input stream Updated ModuleInfo related storage and Course related storage components to accomodate reading from input stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new static method in JsonUtil: readJsonFileFromInputStream
Creates Json object from a string that contains the path of the file that will be read as an input stream.
Manually tested this with the Jar release from this update. No errors so far.
Updated ModuleInfo related storage and Course related storage components to accommodate reading file from input stream